Date: Sun, 28 Mar 1999 19:01:41 -0800
From: Kevin Vajk <[email protected]>
To: [email protected]Subject: Re: X11R6 NetBSD Security Problem
This patch looks pretty good. (Much better than the current situatiuon!!!)
A few comments:
On Fri, 26 Mar 1999, Matthieu Herrb wrote:
> + if (errno == EEXIST) {
> + if (stat(path, &buf) != 0) {
This should be lstat().
> + if (S_ISDIR(buf.st_mode) && ((buf.st_mode & ~S_IFMT) == mode)) {
> + return 0;
> + }
> + }
I think you'll want to check the owner of the directory, too.
- Kevin Vajk
<[email protected]>